Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in metrics.md #902

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Fix typo in metrics.md #902

merged 1 commit into from
Jun 4, 2024

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Jun 4, 2024

  • Fix typo of metric names
  • Add missing metrics

@marctc marctc marked this pull request as ready for review June 4, 2024 09:16
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.88%. Comparing base (ef47785) to head (1629abd).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #902      +/-   ##
==========================================
- Coverage   77.98%   72.88%   -5.10%     
==========================================
  Files         125      125              
  Lines        9124     9124              
==========================================
- Hits         7115     6650     -465     
- Misses       1544     2029     +485     
+ Partials      465      445      -20
Flag Coverage Δ
integration-test ?
k8s-integration-test 58.90% <ø> (-0.13%) ⬇️
oats-test 36.93% <ø> (ø)
unittests 43.70% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mariomac
mariomac approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@marctc marctc merged commit f25feaf into main Jun 4, 2024
8 checks passed
@marctc marctc deleted the fix_metrics_docs branch June 4, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariomac mariomac mariomac approved these changes

@grcevski grcevski Awaiting requested review from grcevski grcevski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marctc @codecov-commenter @mariomac